• Update GeneratedDllImportAttribute CharSet to StringMarshalling
• Update usage in runtime libraries
• Make fixer handle CharSet.Unicode -> StringMarshalling.Utf16
• Did not make fixer handle CharSet.Ansi or CharSet.Auto
  • For ANSI, we could look through all parameters and the return and mark them MarshalAs as needed, but I figured we would just make the fixer handle this once we propose and do some AnsiStringMarshalling using the design in Attributes and Analyzer Diagnostics to support custom struct marshalling in the DllImport Source Generator #46838 and can use that for StringMarshallingCustomType - would be more in line with the original code's intent
  • For Auto, we could define two different p/invokes and update all the callsites to conditionally call different ones. Honestly not convinced this is worth it - we had one use case in all of runtime and that was for invoking into hostpolicy.
• StringMarshalling enum is just added internally (like GeneratedDllImportAttribute) for now. Once we update/rename GeneratedDllImportAttribute per the approved API, we can expose them.

I will rebase / update after #65343 goes in. (done)

Contributes to #46822. #61326